This repository was archived by the owner on Jul 16, 2023. It is now read-only.
feat: add allow-only-once option to no-magic-number rule
#1173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incendial
changed the title
allow-only-once option to no-magic-number ruleallow-only-once option to no-magic-number rule
Codecov Report
@@ Coverage Diff @@
## master #1173 +/- ##
==========================================
+ Coverage 85.59% 85.62% +0.02%
==========================================
Files 350 350
Lines 7928 7944 +16
==========================================
+ Hits 6786 6802 +16
Misses 1142 1142
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
incendial
reviewed
Jan 28, 2023
lib/src/analyzers/lint_analyzer/rules/rules_list/no_magic_number/no_magic_number_rule.dart
Show resolved
Hide resolved
.../src/analyzers/lint_analyzer/rules/rules_list/no_magic_number/no_magic_number_rule_test.dart
Outdated
Show resolved
Hide resolved
incendial
approved these changes
Jan 28, 2023
|
@san-smith thank you for the contribution! 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to an item)
What changes did you make? (Give an overview)
Added a new
allow-only-onceoption to theno-magic-numberrule that allows numeric literals to be used if they occur only once in the scope.Is there anything you'd like reviewers to focus on?