Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

fix: correctly handle - symbol #895

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

@incendial incendial added this to the 4.16.0 milestone Jun 19, 2022
@incendial incendial requested a review from dkrutskikh June 19, 2022 09:09
@incendial incendial self-assigned this Jun 19, 2022
@github-actions
Copy link

github-actions bot commented Jun 19, 2022

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

github-actions bot commented Jun 19, 2022

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 430

  • Total lines of source code: 7568

  • Total classes: 296

  • Average Cyclomatic Number per line of code: 0.35

  • Average Source Lines of Code per method: 6

  • Total tech debt: 1326.0 hours

  • Found issues: 6 ⚠

@codecov
Copy link

codecov bot commented Jun 19, 2022

Codecov Report

Merging #895 (a1b335b) into master (75e0fb7) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a1b335b differs from pull request most recent head f312adc. Consider uploading reports for the commit f312adc to get more accurate results

@@           Coverage Diff           @@
##           master     #895   +/-   ##
=======================================
  Coverage   87.37%   87.37%           
=======================================
  Files         283      283           
  Lines        5997     5997           
=======================================
  Hits         5240     5240           
  Misses        757      757           
Impacted Files Coverage Δ
...st/prefer_commenting_analyzer_ignores/visitor.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f49be8f...f312adc. Read the comment docs.

@dkrutskikh dkrutskikh merged commit 10c3162 into master Jun 20, 2022
@dkrutskikh dkrutskikh deleted the improve-prefer-commenting-ignores branch June 20, 2022 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants