-
-
Notifications
You must be signed in to change notification settings - Fork 711
Docker bug fix #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker bug fix #194
Conversation
@jrbourbeau This is related to an issue you had identified so tagging you here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this @borundev! I wonder if it might be more straightforward to install into the default conda environment (I think this is base
in this case) instead of creating a separate dask-tutorial
environment. That should eliminate the need to modify the selected kernel and ~/.bashrc
file. What do you think?
@jrbourbeau In general I think that if a docker image is intended as an end product then it makes little sense to add other environments. However, when I tried to update the base environment I got conflicts in explicit specs specified earlier. So in this case I think the most straightforward way to handle the issue if the Dockerfile modification that I have made. |
@jrbourbeau , were you satisfied with the above argument? Certainly the fix would be useful. |
Ah, thanks for the ping @martindurant. @borundev and I were actually able to talk about this issue offline and decided to go a slightly different direction. I'll push a commit real quick |
This PR now just updates the base environment which should be activated by default (hope it's okay that I pushed to your branch @borundev) |
The Dockerfile was creating an environment dask-tutorial but then launching jupyter using the default one.
This causes two issues:
I fix that in this PR. It is not as straightforward as running
conda init
and theconda activate environment
as the former requires to launch a new shell which is not possible.The solution is to shell into the correct environment and then run the postBuild script. Furthermore, the notebooks are configured to use the environment python3. This can be solved simply by pointing python3 to dask-tutorial as I have done.
In addition I also make some changes to make sure that logging into a shell in the container activates the correct environment.