Skip to content

Docker bug fix #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 6, 2020
Merged

Docker bug fix #194

merged 4 commits into from
Nov 6, 2020

Conversation

borundev
Copy link
Contributor

@borundev borundev commented Sep 23, 2020

The Dockerfile was creating an environment dask-tutorial but then launching jupyter using the default one.

This causes two issues:

Screenshot from 2020-09-23 12-43-45

  1. Since the notebooks were not using the correct kernel, all packages used were not available and in particular graphviz was not available as pointed out in this issue.

I fix that in this PR. It is not as straightforward as running conda init and the conda activate environment as the former requires to launch a new shell which is not possible.

The solution is to shell into the correct environment and then run the postBuild script. Furthermore, the notebooks are configured to use the environment python3. This can be solved simply by pointing python3 to dask-tutorial as I have done.

In addition I also make some changes to make sure that logging into a shell in the container activates the correct environment.

@borundev
Copy link
Contributor Author

@jrbourbeau This is related to an issue you had identified so tagging you here.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @borundev! I wonder if it might be more straightforward to install into the default conda environment (I think this is base in this case) instead of creating a separate dask-tutorial environment. That should eliminate the need to modify the selected kernel and ~/.bashrc file. What do you think?

@borundev
Copy link
Contributor Author

borundev commented Sep 25, 2020

@jrbourbeau In general I think that if a docker image is intended as an end product then it makes little sense to add other environments.

However, when I tried to update the base environment I got conflicts in explicit specs specified earlier.

So in this case I think the most straightforward way to handle the issue if the Dockerfile modification that I have made.

@martindurant
Copy link
Member

@jrbourbeau , were you satisfied with the above argument? Certainly the fix would be useful.

@jrbourbeau
Copy link
Member

Ah, thanks for the ping @martindurant. @borundev and I were actually able to talk about this issue offline and decided to go a slightly different direction. I'll push a commit real quick

@jrbourbeau
Copy link
Member

This PR now just updates the base environment which should be activated by default (hope it's okay that I pushed to your branch @borundev)

@jrbourbeau jrbourbeau merged commit 2b9db92 into dask:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants