Enables get_namespace to return namespace when input adopts Array API spec #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
approved these changes
Mar 4, 2023
asmeurer
reviewed
Mar 6, 2023
| @@ -12,3 +12,10 @@ def test_get_namespace(library): | |||
| expected_namespace = getattr(array_api_compat, library) | |||
| assert namespace is expected_namespace | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("array_namespace", ["cupy.array_api", "numpy.array_api"]) | |||
| def test_get_namespace_returns_actual_namespace(array_namespace): | |||
There was a problem hiding this comment.
Why is this a separate test from the one above?
There was a problem hiding this comment.
Going to just merge this and fix this and the other issues you opened issues for in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
get_namespaceto return the Array API namespace if the input already adapts the Array API standard.