Skip to content

Rename skipna => skip_nulls #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Rename skipna => skip_nulls #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions spec/API_specification/dataframe_api/dataframe_object.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,61 +464,61 @@ def __iter__(self) -> NoReturn:
"""
raise NotImplementedError("'__iter__' is intentionally not implemented.")

def any(self, skipna: bool = True) -> DataFrame:
def any(self, skip_nulls: bool = True) -> DataFrame:
"""
Reduction returns a 1-row DataFrame.
"""
...

def all(self, skipna: bool = True) -> DataFrame:
def all(self, skip_nulls: bool = True) -> DataFrame:
"""
Reduction returns a 1-row DataFrame.
"""
...

def min(self, skipna: bool = True) -> DataFrame:
def min(self, skip_nulls: bool = True) -> DataFrame:
"""
Reduction returns a 1-row DataFrame.
"""
...

def max(self, skipna: bool = True) -> DataFrame:
def max(self, skip_nulls: bool = True) -> DataFrame:
"""
Reduction returns a 1-row DataFrame.
"""
...

def sum(self, skipna: bool = True) -> DataFrame:
def sum(self, skip_nulls: bool = True) -> DataFrame:
"""
Reduction returns a 1-row DataFrame.
"""
...

def prod(self, skipna: bool = True) -> DataFrame:
def prod(self, skip_nulls: bool = True) -> DataFrame:
"""
Reduction returns a 1-row DataFrame.
"""
...

def median(self, skipna: bool = True) -> DataFrame:
def median(self, skip_nulls: bool = True) -> DataFrame:
"""
Reduction returns a 1-row DataFrame.
"""
...

def mean(self, skipna: bool = True) -> DataFrame:
def mean(self, skip_nulls: bool = True) -> DataFrame:
"""
Reduction returns a 1-row DataFrame.
"""
...

def std(self, skipna: bool = True) -> DataFrame:
def std(self, skip_nulls: bool = True) -> DataFrame:
"""
Reduction returns a 1-row DataFrame.
"""
...

def var(self, skipna: bool = True) -> DataFrame:
def var(self, skip_nulls: bool = True) -> DataFrame:
"""
Reduction returns a 1-row DataFrame.
"""
Expand Down
20 changes: 10 additions & 10 deletions spec/API_specification/dataframe_api/groupby_object.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,32 +5,32 @@


class GroupBy:
def any(self, skipna: bool = True) -> "DataFrame":
def any(self, skip_nulls: bool = True) -> "DataFrame":
...

def all(self, skipna: bool = True) -> "DataFrame":
def all(self, skip_nulls: bool = True) -> "DataFrame":
...

def min(self, skipna: bool = True) -> "DataFrame":
def min(self, skip_nulls: bool = True) -> "DataFrame":
...

def max(self, skipna: bool = True) -> "DataFrame":
def max(self, skip_nulls: bool = True) -> "DataFrame":
...

def sum(self, skipna: bool = True) -> "DataFrame":
def sum(self, skip_nulls: bool = True) -> "DataFrame":
...

def prod(self, skipna: bool = True) -> "DataFrame":
def prod(self, skip_nulls: bool = True) -> "DataFrame":
...

def median(self, skipna: bool = True) -> "DataFrame":
def median(self, skip_nulls: bool = True) -> "DataFrame":
...

def mean(self, skipna: bool = True) -> "DataFrame":
def mean(self, skip_nulls: bool = True) -> "DataFrame":
...

def std(self, skipna: bool = True) -> "DataFrame":
def std(self, skip_nulls: bool = True) -> "DataFrame":
...

def var(self, skipna: bool = True) -> "DataFrame":
def var(self, skip_nulls: bool = True) -> "DataFrame":
...