Skip to content

Feat: Added an ability to pass values from stdin #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2019
Merged

Feat: Added an ability to pass values from stdin #106

merged 2 commits into from
Jan 24, 2019

Conversation

okgolove
Copy link
Contributor

Fixes #101

mumoshu
mumoshu reviewed Jan 24, 2019
View reviewed changes
cmd/helm.go
bytes, err = ioutil.ReadAll(os.Stdin)
} else {
bytes, err = ioutil.ReadFile(filePath)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference: https://github.com/helm/helm/blob/581e6cdbb8e42753556ae48ccba8cef84c40f736/cmd/helm/install.go#L373-L379

mumoshu
mumoshu approved these changes Jan 24, 2019
View reviewed changes
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for your help 🙇

@mumoshu mumoshu merged commit d0f6065 into databus23:master Jan 24, 2019
@okgolove okgolove deleted the read-from-stdout branch January 24, 2019 07:25
@ReillyTevera ReillyTevera mentioned this pull request Apr 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu mumoshu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@okgolove @mumoshu