Skip to content

Support of helm 3 #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Support of helm 3 #150

wants to merge 1 commit into from

Conversation

jonasrutishauser
Copy link
Contributor

Full support of helm v3.0.0-beta.3 and helm 2.

I implemented this independent of #149 but it will be solution for #147 which supports all commands.

mumoshu
mumoshu reviewed Sep 8, 2019
View reviewed changes
cmd/upgrade.go
releaseResponse, err := d.deployedRelease(d.release)
var notDeployed string
if isHelm3() {
notDeployed = fmt.Sprintf("%q has no deployed releases", d.release)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch! I missed this in my PR #149

@mumoshu
Copy link
Collaborator

mumoshu commented Sep 8, 2019

@jonasrutishauser Thanks for your contribution! This looks so nice 💯

I'm now trying to build and test this myself, but had no luck so far.

glide install && HELM_HOME=$HOME/Library/helm make install emits a bunch of compilation errors perhaps due to inconsistent dependencies https://gist.github.com/mumoshu/1dfda422fce533493128fa93f07ef9ac

Do you have any clue on this?

@mumoshu mumoshu mentioned this pull request Sep 8, 2019
Closed
@jonasrutishauser
Copy link
Contributor Author

jonasrutishauser commented Sep 8, 2019 •
edited
Loading

I had many difficulties with glide too and after a glide up the build did not work, but after a make bootstrap which calls glide install --strip-vendor the build worked.
I even used more time with glide than with the implementation.

I tested the build with the go.mod file of #149 and it worked like a charm.

@databus23
Copy link
Owner

@jonasrutishauser Thanks for the PR. I think we need to make a general decision how this plugin should handle the rendering part for helm3 as there are some potential compatibility issues across versions of helm that I'm worried about. I'm glad to here your thought on this comment: #149 (comment)

@databus23
Copy link
Owner

Closed in favour of #151

@databus23 databus23 closed this Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu mumoshu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonasrutishauser @mumoshu @databus23