Disabling grep colouring mode directly for the execution #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Disabling grep colouring mode directly for the execution, because it causes issues when accessing the url with curl if
GREP_COLOR
is set toalways
.As you can see below, curl will use invalid url set by
getDownloadURL
function. The issue is in line 76 of the install/update script where the OS name is grepped. (https://github.com/databus23/helm-diff/blob/master/install-binary.sh#L76)If colouring mode is disabled for grep, it will not include the terminal colouring chars in the download url and the new release can be downloaded.
Full error message