Add support for custom output formats #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergio Morales <[email protected]>
mumoshu
approved these changes
Jul 20, 2020
There was a problem hiding this comment.
@semoac Hey! Thank you so much for this awesome work
This LGTM overall. But can I later make json output format as an alias to the current template output? I think that's more straightforward for users wanting to use json output.
Probably we can easily add yaml output on top of that, but that's another story!
|
@semoac Also - would you mind if we reused your screencaptures in our README? |
Sure. Go ahead! |
mumoshu
added a commit
that referenced
this pull request
Jul 20, 2020
This adds the JSON output on top of #221, which can be enabled by passing `--output json`. Internally it works exactly the same as the `template` output format with the default template. ``` ******************** Release was not present in Helm. Diff will show entire contents as new. ******************** [{ "api": "v1", "kind": "Secret", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" },{ "api": "v1", "kind": "ConfigMap", "namespace": "default", "name": "mysql-1567775891-test", "change": "ADD" },{ "api": "v1", "kind": "PersistentVolumeClaim", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" },{ "api": "v1", "kind": "Service", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" },{ "api": "apps", "kind": "Deployment", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" }] ``` Ref #221 (review)
mumoshu
added a commit
that referenced
this pull request
Jul 20, 2020
This adds the JSON output on top of #221, which can be enabled by passing `--output json`. Internally it works exactly the same as the `template` output format with the default template. ``` ******************** Release was not present in Helm. Diff will show entire contents as new. ******************** [{ "api": "v1", "kind": "Secret", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" },{ "api": "v1", "kind": "ConfigMap", "namespace": "default", "name": "mysql-1567775891-test", "change": "ADD" },{ "api": "v1", "kind": "PersistentVolumeClaim", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" },{ "api": "v1", "kind": "Service", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" },{ "api": "apps", "kind": "Deployment", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" }] ``` Ref #221 (review)
Merged
mumoshu
added a commit
that referenced
this pull request
Jul 20, 2020
This adds the JSON output on top of #221, which can be enabled by passing `--output json`. Internally it works exactly the same as the `template` output format with the default template. ``` ******************** Release was not present in Helm. Diff will show entire contents as new. ******************** [{ "api": "v1", "kind": "Secret", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" },{ "api": "v1", "kind": "ConfigMap", "namespace": "default", "name": "mysql-1567775891-test", "change": "ADD" },{ "api": "v1", "kind": "PersistentVolumeClaim", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" },{ "api": "v1", "kind": "Service", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" },{ "api": "apps", "kind": "Deployment", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" }] ``` Ref #221 (review)
mumoshu
added a commit
that referenced
this pull request
Jul 21, 2020
This adds the JSON output on top of #221, which can be enabled by passing `--output json`. Internally it works exactly the same as the `template` output format with the default template. ``` ******************** Release was not present in Helm. Diff will show entire contents as new. ******************** [{ "api": "v1", "kind": "Secret", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" },{ "api": "v1", "kind": "ConfigMap", "namespace": "default", "name": "mysql-1567775891-test", "change": "ADD" },{ "api": "v1", "kind": "PersistentVolumeClaim", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" },{ "api": "v1", "kind": "Service", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" },{ "api": "apps", "kind": "Deployment", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" }] ``` Ref #221 (review)
mumoshu
added a commit
that referenced
this pull request
Jul 21, 2020
This adds the JSON output on top of #221, which can be enabled by passing `--output json`. Internally it works exactly the same as the `template` output format with the default template. ``` ******************** Release was not present in Helm. Diff will show entire contents as new. ******************** [{ "api": "v1", "kind": "Secret", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" },{ "api": "v1", "kind": "ConfigMap", "namespace": "default", "name": "mysql-1567775891-test", "change": "ADD" },{ "api": "v1", "kind": "PersistentVolumeClaim", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" },{ "api": "v1", "kind": "Service", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" },{ "api": "apps", "kind": "Deployment", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" }] ``` Ref #221 (review)
mumoshu
added a commit
that referenced
this pull request
Jul 21, 2020
This adds the JSON output on top of #221, which can be enabled by passing `--output json`. Internally it works exactly the same as the `template` output format with the default template. ``` ******************** Release was not present in Helm. Diff will show entire contents as new. ******************** [{ "api": "v1", "kind": "Secret", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" },{ "api": "v1", "kind": "ConfigMap", "namespace": "default", "name": "mysql-1567775891-test", "change": "ADD" },{ "api": "v1", "kind": "PersistentVolumeClaim", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" },{ "api": "v1", "kind": "Service", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" },{ "api": "apps", "kind": "Deployment", "namespace": "default", "name": "mysql-1567775891", "change": "ADD" }] ``` Ref #221 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I was using these changes to format the output of helm-diff and I think it may be useful to someone else.
I use these formats to help me make decisions during my CI/CD pipeline on whatever or not the changes should be applied unsupervised. They also help me reduce the visual noise when
helmfilehas to process a lot of releases.I also been using the "template" output format to feed data to external system that needs to know what resource could be affected on upgrades.
This PR do not fix anything. I'm just sharing code. Please feel free to reject it without explanation.
Examples
Simple with helmfile
Template with a json like output