Skip to content

Add linux/arm64 support #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 5, 2022
Merged

Conversation

dschaaff
Copy link
Contributor

@dschaaff dschaaff commented Mar 11, 2021

This adds a build for linux/arm64 architectures.

I am currently using this in my environment via https://github.com/dschaaff/helm-diff/releases/tag/v3.1.3-arm .

Resolves #275

dschaaff and others added 4 commits March 10, 2021 16:40
add linux-arm64 to supported architectures
Signed-off-by: Daniel Schaaff <[email protected]>
@mumoshu
Copy link
Collaborator

mumoshu commented May 18, 2021

Let me link this to #275

@Alexand
Copy link

Alexand commented Jun 17, 2021

Thanks a lot @mumoshu and @dschaaff for working on this improvement! ❤️

Yusuke, would there be an estimation date for Daniel's MR to get released?

GitLab provides a docker image that entails this great library together with Helmfile. Some users would like to benefit from it on arm64. So I'm just trying to get an idea, if possible, of when we could also make use of it.

@stale
Copy link

stale bot commented Sep 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 19, 2021
@dschaaff
Copy link
Contributor Author

Not stale

@stale stale bot removed the stale label Sep 19, 2021
@WyriHaximus
Copy link

@dschaaff Is there a way to use your fork directly? Tried both helm plugin install https://github.com/dschaaff/helm-diff/ and helm plugin install https://github.com/dschaaff/helm-diff/releases/download/v3.1.3-arm/helm-diff-linux-arm64.tgz and neither worked.

@dschaaff
Copy link
Contributor Author

dschaaff commented Nov 1, 2021

@dschaaff Is there a way to use your fork directly? Tried both helm plugin install https://github.com/dschaaff/helm-diff/ and helm plugin install https://github.com/dschaaff/helm-diff/releases/download/v3.1.3-arm/helm-diff-linux-arm64.tgz and neither worked.

You can try the binary I have here https://github.com/dschaaff/helm-diff/releases.

@morganchristiansson
Copy link

morganchristiansson commented Dec 13, 2021

Is this ready to merge? The last helm-diff release is from June last year... hmm

Adding -$ARCH to release filenames is a good decision.

@michaelsauter
Copy link

We'd also be very interested in this (opendevstack/ods-pipeline#360). Now that #294 is merged, helm-diff can be used on M1, but not from within containers. I think this is a relatively common use case so it would be great to get this merged!

ping @mumoshu 😄

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've recently introduced macos/arm64 support and it would make sense to include arm64 support for linux too! So, LGTM. Thanks a lot for your patience and efforts everyone, and especially @dschaaff ☺️

@mumoshu mumoshu merged commit 4790fb1 into databus23:master Jan 5, 2022
@damienpontifex damienpontifex mentioned this pull request Jan 5, 2022
@damienpontifex
Copy link

This now requires a new GitHub release with architecture specific named artifacts. See #322 but when running without --version flag, the grep $ARCH fails and hence $DOWNLOAD_URL is empty and subsequently error shows up as curl failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ARM binaries to releases (Plugin install fails on Raspberry Pi)
7 participants