-
Notifications
You must be signed in to change notification settings - Fork 292
Add linux/arm64 support #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add linux-arm64 to supported architectures
Signed-off-by: Daniel Schaaff <[email protected]>
Signed-off-by: Daniel Schaaff <[email protected]>
…osetta works Signed-off-by: Daniel Schaaff <[email protected]>
Let me link this to #275 |
Signed-off-by: Daniel Schaaff <[email protected]>
Thanks a lot @mumoshu and @dschaaff for working on this improvement! ❤️ Yusuke, would there be an estimation date for Daniel's MR to get released? GitLab provides a docker image that entails this great library together with Helmfile. Some users would like to benefit from it on arm64. So I'm just trying to get an idea, if possible, of when we could also make use of it. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Not stale |
@dschaaff Is there a way to use your fork directly? Tried both |
You can try the binary I have here https://github.com/dschaaff/helm-diff/releases. |
Is this ready to merge? The last helm-diff release is from June last year... hmm Adding -$ARCH to release filenames is a good decision. |
We'd also be very interested in this (opendevstack/ods-pipeline#360). Now that #294 is merged, ping @mumoshu 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've recently introduced macos/arm64 support and it would make sense to include arm64 support for linux too! So, LGTM. Thanks a lot for your patience and efforts everyone, and especially @dschaaff
This now requires a new GitHub release with architecture specific named artifacts. See #322 but when running without |
This adds a build for linux/arm64 architectures.
I am currently using this in my environment via https://github.com/dschaaff/helm-diff/releases/tag/v3.1.3-arm .
Resolves #275