Skip to content

FLAG: add an option to ignore the error if the release doesn't exist yet #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jeff-knurek
Copy link
Contributor

I ran into the issue described here today #15
I kind of agree that helm-diff shouldn't be responsible for replacing --dry-run --debug/template

but when building helm diff into CI, a new project might not always exist, and suppressing all errors from helm diff is not desirable. So I created this simplified version of the original PR.

@mumoshu
Copy link
Collaborator

mumoshu commented Apr 12, 2018

@jeff-knurek Hi!

I kind of agree that helm-diff shouldn't be responsible for replacing --dry-run --debug/template

Would you still think so even when the regular diff command allows similar thing?

$ diff --help | grep new-file
  -N  --new-file  Treat absent files as empty.
  --unidirectional-new-file  Treat absent first files as empty.

A more detailed context: #15 (comment)

Just wanted to sync up with you based on the seemingly necessary information 😉

Anyway, the usefulness of this feature would be pretty orthogonal to #15. Good job!

@jeff-knurek
Copy link
Contributor Author

hmm, that's a good point. I guess that's why I only "kind of agreed" 😄

@jeff-knurek jeff-knurek mentioned this pull request May 24, 2018
@jeff-knurek jeff-knurek closed this Jun 4, 2018
@jeff-knurek jeff-knurek deleted the flag-to-ingore-new branch June 4, 2018 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants