add namespace to deduplication tuple #41
Conversation
|
Did you test this? In my case the Namespace is empty. I guess thats because it was not specified in the templates rendered by helm. Maybe we should provide a string like |
|
Or maybe we even pass in the release namespace into the |
novas0x2a
force-pushed
the
namespace-aware
branch
from
4e2fbc4 to
9835a2b
Compare
|
Okay, finally got around to learning more about the helm api; this seems to do the right thing now. |
novas0x2a
force-pushed
the
namespace-aware
branch
from
9835a2b to
5667b59
Compare
|
Noticed there was a conflict; rebased it. |
|
@novas0x2a Sorry but this got to conflict badly with the current master. Would you mind rebasing when you have some time? I'm still considering this as an important edge-case to be addressed. |
helm charts can deploy to multiple namespaces at once, so compare on (namespace, name, kind, version) instead of just (name, kind, version). If no namespace is parsed from the manifest, the helm release namespace is used instead.
novas0x2a
force-pushed
the
namespace-aware
branch
from
5667b59 to
8fa52bb
Compare
|
rebased again. |
|
@novas0x2a Sorry it took some time to test this manually on my side. LGTM. Thanks for your patience, and awesome work! |
helm charts can deploy to multiple namespaces at once, so compare on
(namespace, name, kind, version) instead of just (name, kind, version).
(We're deploying ResourceQuotas with the same name across multiple namespaces)