fix install-binary.sh version specification #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where the --version flag that can be passed to `helm plugin install` was not working with the install-binary.sh script that this repository uses to install the binary files for users. The issue was that the Helm runs install hooks in the current working directory [1], so the `git describe` command that this repository was executing was not being executed in the directory of the plugin, and would thus always fail. The fix here is to use the `-C` flag to git to specify the directory of the plugin source, ensuring that it will work correctly regardless of the working directory from which the script is executed. Closes databus23#50 [1] https://github.com/kubernetes/helm/blob/401f8bcc187d7a9edeec12c26c64819f105954d5/cmd/helm/plugin.go#L48-L72
|
Thanks for figuring this out! |
|
Sure thing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the --version flag that can be passed to
helm plugin installwas not working with the install-binary.sh script thatthis repository uses to install the binary files for users.
The issue was that the Helm runs install hooks in the current working
directory [1], so the
git describecommand that this repository wasexecuting was not being executed in the directory of the plugin, and
would thus always fail. The fix here is to use the
-Cflag to git tospecify the directory of the plugin source, ensuring that it will work
correctly regardless of the working directory from which the script is
executed.
Closes #50
[1] https://github.com/kubernetes/helm/blob/401f8bcc187d7a9edeec12c26c64819f105954d5/cmd/helm/plugin.go#L48-L72