return non-zero exitcode when encountering any change on upgrade #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cmeury Thanks for your contribution across projects 👍This LGTM overall, would you mind rebasing? Also, I'm fine with adding |
|
Update:
This turned out to be not that easy(obviously? 😃) due to that helm-diff needs |
|
Trying to rebase this onto master. |
mumoshu
added a commit
to mumoshu/helm-diff
that referenced
this pull request
Jul 25, 2018
I have mistakenly introduced a build error due to my merge mistake while resolving conflicts in databus23#65. This fixes that.
mumoshu
added a commit
that referenced
this pull request
Jul 25, 2018
I have mistakenly introduced a build error due to my merge mistake while resolving conflicts in #65. This fixes that.
mumoshu
added a commit
to mumoshu/helm-diff
that referenced
this pull request
Jul 25, 2018
This feature is enabled only when the `--detailed-exitcode` flag (databus23#65) is provided. Supports `upgrade`, `revision` and `rollback` sub-commands. Resolves databus23#54, but only after helm/helm#4367 as released with helm v2.11.0, probably.
mumoshu
added a commit
to mumoshu/helm-diff
that referenced
this pull request
Jul 25, 2018
This feature is enabled only when the `--detailed-exitcode` flag (databus23#65) is provided. Supports `upgrade`, `revision` and `rollback` sub-commands. Resolves databus23#54, but only after helm/helm#4367 is released with helm v2.11.0, probably.
mumoshu
added a commit
to mumoshu/helm-diff
that referenced
this pull request
Jul 25, 2018
This feature is enabled only when the `--detailed-exitcode` flag (databus23#65) is provided. Supports `upgrade`, `revision` and `rollback` sub-commands. Resolves databus23#54, but only after helm/helm#4367 is released with helm v2.11.0, probably.
mumoshu
added a commit
that referenced
this pull request
Jul 25, 2018
This feature is enabled only when the `--detailed-exitcode` flag (#65) is provided. Supports `upgrade`, `revision` and `rollback` sub-commands. Resolves #54, but only after helm/helm#4367 is released with helm v2.11.0, probably.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at resolving #54, maybe someone can pick it up and build on it?