Skip to content

add --set-string flag to ensure proper parsing of strings #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2018

Conversation

kujenga
Copy link
Contributor

@kujenga kujenga commented Aug 21, 2018

This resolves an issue where numeric values intended to be
used as strings could be interpreted as float64 values,
causing varius things to fail in unexpected ways.

This fix mirrors the changes in the following PR to Helm
itself: helm/helm#3599

Closes #83

This resolves an issue where numeric values intended to be
used as strings could be interpreted as float64 values,
causing varius things to fail in unexpected ways.

This fix mirrors the changes in the following PR to Helm
itself: helm/helm#3599

Closes databus23#83
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for your contribution @kujenga!

@mumoshu mumoshu merged commit 06a6441 into databus23:master Aug 27, 2018
@kujenga kujenga deleted the at/add-set-string branch August 29, 2018 20:00
@kujenga
Copy link
Contributor Author

kujenga commented Aug 29, 2018

Awesome, happy to lend a hand!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--set flag parses numbers as float64
2 participants