Skip to content

add --set-file support #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2018
Merged

add --set-file support #95

merged 1 commit into from
Sep 21, 2018

Conversation

ctiml
Copy link
Contributor

@ctiml ctiml commented Sep 12, 2018

Closes #94

@clkao
Copy link

clkao commented Sep 17, 2018

@mumoshu any chance you can help reviewing this?

mumoshu
mumoshu approved these changes Sep 21, 2018
View reviewed changes
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much for your supports @ctiml and @clkao 👍

@mumoshu mumoshu merged commit 11e3744 into databus23:master Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu mumoshu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctiml @clkao @mumoshu