Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

support 3 part identifer for snowflake #335

Merged

Conversation

dlawin
Copy link
Contributor

@dlawin dlawin commented Dec 6, 2022

Snowflake: Allows specifying database as well when t1, t2 share a connection. Example:

t1 = connect_to_table(CONN_INFO, ("DEV", "DEV_SCHEMA", "TABLE"), "ID")
t2 = connect_to_table(CONN_INFO, ("PROD", "PROD_SCHEMA", "TABLE"), "ID")
diff = diff_tables(t1, t2, algorithm=Algorithm.JOINDIFF)

or

t1 = connect_to_table(CONN_INFO, "DEV.DEV_SCHEMA.TABLE", "ID")
t2 = connect_to_table(CONN_INFO, "PROD.PROD_SCHEMA.TABLE", "ID")
diff = diff_tables(t1, t2, algorithm=Algorithm.JOINDIFF)

@dlawin dlawin requested a review from erezsh December 6, 2022 18:13
@dlawin dlawin self-assigned this Dec 6, 2022
@linear
Copy link

linear bot commented Dec 6, 2022

Copy link
Contributor

@erezsh erezsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants