This repository was archived by the owner on May 17, 2024. It is now read-only.
Add 'where' argument to Python API #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to pass now.. Let's see if it happens again. Meanwhile, please rebase and flatten into atomic commits. |
leoebfolsom
force-pushed
the
add-where-argument
branch
from
50f64d8 to
9407a5a
Compare
leoebfolsom
force-pushed
the
add-where-argument
branch
from
316a75e to
f1c5b5c
Compare
|
@erezsh I think I've successfully rebased and flattened into one commit. Please review, thanks! |
|
Looks good! |
|
🥳 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
whereargument was not available in the Python API. This fixes that error of omission to create behavior that's consistent with a) the CLI behavior, and b) the Python API documentation.