This repository was archived by the owner on May 17, 2024. It is now read-only.
allow joindiff across bigquery projects #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segv
force-pushed
the
master
branch
2 times, most recently
from
ba494a0 to
e96178f
Compare
|
Why not just follow the simple way we implemented it for snowflake, where you use the same database connection, but then specify a different project in the table path? |
My brain just didn't make the connection that this was what you were talking about. PR updated. |
|
Looking better! I believe the change in |
|
(don't worry about the CI error, it's a problem on our end) |
|
I reverted the |
|
Thank you for contributing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.