This repository was archived by the owner on May 17, 2024. It is now read-only.
Add env variables support in .toml config #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pik94
approved these changes
Jan 18, 2023
leoebfolsom
approved these changes
Jan 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add env variables support in
.tomlconfig (#278).Obvious syntax options were:
{ENV_VAR}like Python f-strings or.format().$ENV_VARlike in shell scripts.${ENV_VAR}is also widely used. For example, in docker-compose.I suggest using
${ENV_VAR}, mainly because:$ENV_VAR, we can probably get away without escaping special characters with this approach.However, I don't mind switching format if, for some reason,
${ENV_VAR}doesn't work for us.