This repository was archived by the owner on May 17, 2024. It is now read-only.
Add events for dbt feature #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlawin
commented
Feb 6, 2023
| @@ -72,3 +72,8 @@ def get_timestamp(_match): | |||
| return datetime.now().isoformat("_", "seconds").replace(":", "_") | |||
|
|
|||
| return re.sub("%t", get_timestamp, name) | |||
|
|
|||
|
|
|||
| def truncate_error(error: str): | |||
There was a problem hiding this comment.
moved this from diff_tables.py so I can reuse it
dlawin
commented
Feb 6, 2023
| @@ -85,12 +85,14 @@ def create_start_event_json(diff_options: Dict[str, Any]): | |||
| def create_end_event_json( | |||
| is_success: bool, | |||
| runtime_seconds: float, | |||
| db1: str, | |||
| db2: str, | |||
| data_source_1_type: str, | |||
There was a problem hiding this comment.
I changed these two just because I found the names confusing/misleading
There was a problem hiding this comment.
non-blocking: I'll need to update downstream reporting
There was a problem hiding this comment.
this just impacts the python code, the actual event is not affected
There was a problem hiding this comment.
oh I see, still "data_source_1_type" 👍
kylemcnair
approved these changes
Feb 8, 2023
|
@dlawin Looks okay to me. Did you run black? |
|
Done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new events for the
--cloudoptionSets a new entrypoint
CLI-dbtfor--dbtand--cloudAdded additional parameters to end_event in order to differentiate
--cloudeventsMost of the information is hardcoded to 0/None/etc. on the end event as we don't currently have the related information. Since I think it's likely we will be adding polling and diff results for
--cloudin the near future, I thought it made sense to reuse the existing event structure.