-
Notifications
You must be signed in to change notification settings - Fork 288
Conversation
@erezsh first, please note that this is a new PR now that Dan's dbt integration is merged into master. I've made all the changes suggested by you and Dan in the previous PR except for using zip() / unzip(). I found some explainers since My goal is to add to keep track of conflicts for each of the I can see how it's repetitive to iterate through However, I'm struggling to see where I could gain efficiency using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with the performance/readability caveats I've mentioned
This reverts commit b4b3008.
This reverts commit b4b3008.
My attempt at improving the CLI printout without using any additional python packages.
BEFORE:

AFTER:

TODO based on comments in dlawin#3:
get_stats_string(self, is_dbt:bool = False):
... add the additional functionality there and just wrap it in anif is_dbt:
lightweight cli output update dlawin/data-diff#3 (comment)