Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

add redshift, postgres, databricks support #382

Merged
merged 4 commits into from
Mar 3, 2023

Conversation

dlawin
Copy link
Contributor

@dlawin dlawin commented Feb 6, 2023

Adds conn parsing for redshift, postgres, databricks

Note that I changed the max supported version constant. We can't support dbt versions >= 1.4.2 as the manifest.json doesn't align with the posted json schema

@dlawin dlawin self-assigned this Feb 6, 2023
@dlawin dlawin marked this pull request as ready for review March 3, 2023 22:29
@dlawin dlawin changed the title Draft changes for addl conn_types add redshift, postgres, databricks support Mar 3, 2023
@dlawin dlawin requested review from erezsh, nolar and williebsweet March 3, 2023 22:31
@dlawin dlawin merged commit e5f9121 into datafold:master Mar 3, 2023
@bolinzzz
Copy link

bolinzzz commented Apr 4, 2023

Hi team, I followed the instructions here for dbt integration (Redshift)

When I did pip install data-diff 'data-diff[redshift]' -U, I received the following warning message:
WARNING: data-diff 0.6.0 does not provide the extra 'redshift'

Also when I tried running data-diff --dbt, I am getting the following errors:

[16:46:33] WARNING - Failure while finding unique cols: list index out of range
[16:46:33] WARNING - Failure while finding unique cols: list index out of range
[16:46:33] WARNING - Failure while finding unique cols: list index out of range
[16:46:33] WARNING - Failure while finding unique cols: list index out of range
Running with data-diff=0.6.0

[16:46:33] ERROR - Only password authentication is currently supported for Redshift.

Could you advise me how to proceed with this, thanks!

@williebsweet
Copy link
Contributor

@bolinzzz this might be an error in our docs (cc @dlawin). I think redshift actually uses the postgres connector. Can you try installing that?

@dlawin
Copy link
Contributor Author

dlawin commented Apr 4, 2023

@bolinzzz

[16:46:33] ERROR - Only password authentication is currently supported for Redshift.

Is this the connection method you are using for dbt redshift? https://docs.getdbt.com/reference/warehouse-setups/redshift-setup#password-based-authentication

@dlawin
Copy link
Contributor Author

dlawin commented Apr 4, 2023

@bolinzzz

[16:46:33] WARNING - Failure while finding unique cols: list index out of range

#476 issue here

@bolinzzz
Copy link

bolinzzz commented Apr 5, 2023

Thank you for looking into this!
@dlawin Yeap, I have been using password-based authentication, here's the skeleton for my dbt profile at ~/.dbt/profiles.yml:


default:
  outputs:
    no_prefix:
      type: redshift
      threads: 
      host: 
      port: 
      user: 
      pass: 
      dbname: 
      schema: 

@williebsweet getting the same errors with postgres connector.

@dlawin
Copy link
Contributor Author

dlawin commented Apr 5, 2023

Thank you for looking into this! @dlawin Yeap, I have been using password-based authentication, here's the skeleton for my dbt profile at ~/.dbt/profiles.yml:


default:
  outputs:
    no_prefix:
      type: redshift
      threads: 
      host: 
      port: 
      user: 
      pass: 
      dbname: 
      schema: 
      pass: 

We're expecting the password to be named password: , I'm surprised this works with dbt given I don't see it here https://docs.getdbt.com/reference/warehouse-setups/redshift-setup

I'll open an issue to add pass: as an alternate key, but if you'd like to use this in the interim, password: should work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants