Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

reverse order of dev and prod tables in cli printout and cloud diffs #389

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

leoebfolsom
Copy link
Contributor

@leoebfolsom leoebfolsom commented Feb 13, 2023

Addressing #388 .

Screenshot 2023-02-13 at 14 21 30

Screenshot 2023-02-13 at 14 22 22

@leoebfolsom leoebfolsom marked this pull request as ready for review February 13, 2023 22:23
@kylemcnair
Copy link
Contributor

Seems like tests need to be updated with the new order too:
https://github.com/datafold/data-diff/blob/master/tests/test_dbt.py#L428

        self.assertEqual(request_data_dict["table1"], dev_qualified_list)
        self.assertEqual(request_data_dict["table2"], prod_qualified_list)

just the first failure I looked at, didn't go through them all

@leoebfolsom
Copy link
Contributor Author

leoebfolsom commented Feb 13, 2023

Thanks @kylemcnair! I think there was only the one failure--I've fixed that, so let's see if CI passes now.

Copy link
Contributor

@williebsweet williebsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - pending Dan's review as well

@williebsweet williebsweet requested a review from dlawin February 14, 2023 15:10
@williebsweet williebsweet merged commit 91e1d98 into datafold:master Feb 14, 2023
@leoebfolsom leoebfolsom deleted the reverse-table1-table2-order branch February 14, 2023 18:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants