This repository was archived by the owner on May 17, 2024. It is now read-only.
Align PK support with Datafold SaaS #446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlawin
added
enhancement
dlawin
changed the title
dlawin
changed the title
dlawin
commented
Mar 21, 2023
dlawin
commented
Mar 21, 2023
williebsweet
approved these changes
Mar 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #439
Resolves #438
Allows PKs to be set via any of the options here: https://docs.datafold.com/integrations/orchestration/dbt_adv_config#primary-keys
The PK tag remains hardcoded to "primary-key". Not sure if it's useful to make that customizable.
The pk source is logged to debug (also noticed the logger was actually broken so I fixed that)
Moved more of the parser functionality to happen during init so it can be reused