This repository was archived by the owner on May 17, 2024. It is now read-only.
expand --cloud output by polling for results #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlawin
added
enhancement
dlawin
force-pushed
the
issue_460
branch
2 times, most recently
from
05cefb8 to
3139ab1
Compare
dlawin
commented
Mar 31, 2023
williebsweet
approved these changes
Mar 31, 2023
williebsweet
approved these changes
Mar 31, 2023
This was referenced Mar 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #460
This PR expands the output of
--cloudby polling the datafold api for diff results.Currently the API does not expose the columns added or removed, so this is a limitation until the api is updated (also in progress).
These screenshots hopefully help illustrate the current state as a comparison (there is a local and --cloud diff in each):
Note the missing added/removed below:
