This repository was archived by the owner on May 17, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 288
Embed sqeleton with git history preserved #485
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial code copied from data-diff
Added main with repl command
PR #20 with added infrastructure (TimestampTZ repr)
Add snowflake date mapping
snowflake: add support for key password
query() now accepts list[dict] added more aggregation functions (min, max) added more typing info added exists() api function bugfix in ast.Func
Various changes
Support smallint for Redshift
Closed
Fix type conversion in Presto
Needs some conflict resolution, but let's get this done ASAP. |
…hout the connection editor)
Otherwise, it will conflict with the existing standalone package of that name, unless it is manually remove from virtualenvs.
This force-push is a replay of the same changes on top of the newer main branches in both repos. Also, sqeleton docs are removed. The TUI for "connection editor" is also removed to resolve the package conflict for Textual (see the PR description). |
vvkh
approved these changes
Apr 20, 2023
This was referenced May 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We modify & release
sqeleton
&data-diff
in sync quite often. The latter strictly depends on newer versions of the former. However, the former (sqeleton) is not widely adapted as a standalone library, so this process is rather a burden and does not bring benefits. Also see #480 (comment)It would be easier to modify the source code & release the data-diff library in one step. So, we merged data-diff & sqeleton for now. But we keep the possibility of their splitting indefinitely later.
sqeleton
remains a top-level package for backward compatibility with the existing code (e.g.import sqeleton
).sqeleton
is also moved deep into thedata_diff
package, so that it does not conflict with the existent package name if it is preinstalled in the virtualenvs from before.The git history & code authorship are preserved. Sqeleton's git tags are lost — not to cause conflict with data-diff's tags. However, the historic version numbers are available in the code. Sqeleton's metadata is anyway removed after the merge.
👀Reviewers: There are too many commits. Only look at the latest two where the merge happens — named "Embed sqeleton into data-diff for synchronous changes & releases".
TODOs:
sqeleton
from the existing venvs and pinned requirements — to avoid the package name conflict?data_diff.sqeleton
. The only drawback is a lengthy package name.)Essentially, this was done:
Then resolve all the conflicts, shuffle the files in their appropriate places (CI, docs, package metadata), cross-link then as needed, commit and push.
dbt-core upgrade and/or TUI+
textual
removal: It is caused by a version conflict in data-diff - sqeleton - textual - typing-extension chain. It can be revealed in a pure-sqeleton venv:Version 1.0.0 is the minimum allowed in data-diff now. The conflicting requirement (link):
It was relaxed in dbt-core 1.1.0 — the next one after 1.0.9 (link). The latter also requires Python>=3.7.2, which is not a big deal to upgrade.
It was not noticed because the
sqeleton[tui]
was not installed in CI, but the issue was always there. To resolve it, we either have to (1) upgrade dbt-core from ^1.0.0 to ^1.1.0, but this will break things for dbt-core 1.0.x users, if any; (2) drop sqeleton’s “connection editor” in the embedded code; (3) make that TUI runnable only if textual is installed, fail otherwise, but do not put it in the dependencies explicitly — to be decided.