handle all custom schemas scenarios

[dlawin]

To (hopefully) cover all custom schemas scenarios I've reworked some of the data_diff variables in dbt_project.yml

vars:
  data_diff:
    prod_database: analytics-383622
    prod_schema: prod # default
    prod_custom_schema: prod_<custom_schema> # falls back to default when there is no custom schema

• Removed custom_schemas boolean
• Added prod_custom_schema
  • When a model has a custom schema, the <custom_schema> will be replaced with the custom schema name
  • Using the example above
    • config(schema = 'marketing') -> analytics-383622.prod_marketing.model
    • No custom schema -> analytics-383622.prod.model

Additional examples:

vars:
 data_diff:
   prod_database: analytics-383622
   prod_schema: prod # default
   prod_custom_schema: <custom_schema> # falls back to default when there is no custom schema

• config(schema = 'marketing') -> analytics-383622.marketing.model
• No custom schema -> analytics-383622.prod.model

vars:
  data_diff:
    prod_database: analytics-383622
    prod_schema: prod # default

• config(schema = 'marketing') -> Error:
  
• No custom schema -> analytics-383622.prod.model

vars:
  data_diff:
    prod_database: analytics-383622

• schema always matches dev
  • analytics.marketing.model <> dev_dan.marketing.model

Resolves #447
Resolves partially #454

[kylemcnair]

Outside the scope of this PR, but do you see a similar approach working for custom DBs? @dlawin

[dlawin]

Outside the scope of this PR, but do you see a similar approach working for custom DBs? @dlawin

yeah I think the same sort of pattern replacement would work there, I'm not very familiar with how folks typically use custom databases though

[dlawin]

Outside the scope of this PR, but do you see a similar approach working for custom DBs? @dlawin

yeah I think the same sort of pattern replacement would work there, I'm not very familiar with how folks typically use custom databases though

Something like:

vars:
 data_diff:
   prod_database: analytics-383622 #default
   prod_custom_database: <custom_database> # used when there is a config(database='blah')
   prod_schema: prod # default
   prod_custom_schema: <custom_schema> # falls back to default when there is no custom schema

[CoreyGaunt]

This is a great refactor! Thanks for digging in on this @dlawin!