Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Make temp schema optional #509

Merged
merged 6 commits into from
Apr 20, 2023
Merged

Make temp schema optional #509

merged 6 commits into from
Apr 20, 2023

Conversation

pik94
Copy link
Contributor

@pik94 pik94 commented Apr 19, 2023 •
edited
Loading

Changes:

  • Prompt to a default value for a temporary schema when creating a new data source in the Datafold cloud
  • Fix a bug with incorrect passing of bigquery credentials.
  • Align database cred parameters of dbt project yml with a datafold db cred ones
  • Accept a json string or a path to a json file with creds for bigquery data source

@williebsweet williebsweet removed the request for review from arimbr April 19, 2023 15:46
@pik94 pik94 self-assigned this Apr 19, 2023
@pik94 pik94 added --dbt Issues/features related to the dbt integration cloud Issues related to data-diff <> Datafold Cloud interaction bug Something isn't working enhancement New feature or request labels Apr 19, 2023
@pik94 pik94 merged commit bbb406f into datafold:master Apr 20, 2023
@pik94 pik94 deleted the make-temp-schema-optional branch April 20, 2023 16:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dlawin dlawin dlawin approved these changes

@nolar nolar Awaiting requested review from nolar

@williebsweet williebsweet Awaiting requested review from williebsweet

Assignees

@pik94 pik94

Labels
--dbt Issues/features related to the dbt integration bug Something isn't working cloud Issues related to data-diff <> Datafold Cloud interaction enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pik94 @dlawin