This repository was archived by the owner on May 17, 2024. It is now read-only.
add --state flag feature to dbt integration #600
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new flag
--state
for use with the dbt integrationA user can use this flag to specify the "production" manifest location e.g.:
data-diff --dbt --state ~/prod_manifest.json
This removes the need for configuration in the dbt_project.yml, and covers scenarios not covered via configuration. The prod manifest is used as the source of truth for production model locations vs. via configuration.
Changes:
prod_manifest_obj
to DbtParsermanifest_obj
in DbtParser todev_manifest_obj
to differentiateDbtParser.get_datadiff_variables
toDbtParser.get_datadiff_config
(this was easily confused with _get_diff_vars)_get_prod_path_from_manifest
_get_prod_path_from_config
DataDiffDbtProjectVarsNotFoundError
now thrown when config is not present AND not using --stateResolves #454