This repository was archived by the owner on May 17, 2024. It is now read-only.
Initialise mutable fields of dataclasses safely for reuse #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, if the differs are reused multiple times within the same process, there is a risk of leaking accumulated data from the previous runs into the following runs.
In some cases, it can be "solved" by re-initializing these fields explicitly before data accumulation (e.g.
self.fld = {...}), or by overwriting the same dict keys on every run — but neither of these is reliable. The field's content must be strictly coupled to the containing object and its lifetime and also disposed of when the object is disposed of.