This repository was archived by the owner on May 17, 2024. It is now read-only.
Simplify: Squash database-specialised mixins into their database-specialised dialects #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 24, 2023 15:38
All the Presto mixins are already inherited into the Trino dialect via its base class, so there is no need to duplicate the mixins.
All the Postgres mixins are already inherited into the Redshift dialect via its base class, so there is no need to duplicate the mixins.
dlawin
approved these changes
Oct 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little improvements step by step:
This time, squash the database-specialised mixins into their corresponding database-specialised dialects — since these mixins are not reused anywhere else.
In particular, resolve the Postgres-Redshift & Presto-Trino pairs with double inheritance of the same methods (first, inherited from the parent dialect class; second, inherited from the parent mixins, which are already included in the parent dialect class).
This PR does NOT touch the "abstract" mixins yet — to be made later (they are not currently included in the base Dialect class, so this change will need extra care).
Reviewer hints: There are no changes in the code & logic itself, but only moves of methods up & down between classes. The big green & red diffs are there because of how git & GitHub detect such changes.