v1.3.1 - Merge duration and documentation fixes #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…docs and tests * Updated ExecutionOptions.yaml and Session.yaml to move execution option descriptions to a table in Session.execute's method description. * Cleaned up Session.executeGraph execution options to be in a table in the method description. * Update ExecutionOptions::__construct refs in Core.yaml to point to Session.execute().
* Moved common doc generator functionality into a common file.
* Fixed unnecessary use of '{@inheritdoc}' in cases that wouldn't
be caught by the `doc_generate_yaml.php` updates.
* When generating the PHP API comments will be inherited from the
parent if the subclass's comment is empty.
* Fixed invalid `Dse\Table` comment
* Fixed wrapping @return comments
mikefero
approved these changes
May 11, 2017
| @@ -533,4 +531,4 @@ The PHP Driver follows the architecture of [the C/C++ Driver](http://datastax.gi | |||
|
|
|||
| ### Persistent sessions | |||
There was a problem hiding this comment.
I feel we can remove this section entirely from the Architecture portion as Persistent Sessions are discussed at the beginning of this documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.