Skip to content

[PHP-22] Schema Metadata Feature and Miscellaneous Windows Fixes #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 11, 2015
Merged

[PHP-22] Schema Metadata Feature and Miscellaneous Windows Fixes #52

merged 10 commits into from
Sep 11, 2015

Conversation

mikefero
Copy link
Contributor

No description provided.

avalanche123
avalanche123 reviewed Sep 10, 2015
View reviewed changes
features/schema_metadata.feature
->build();
$session = $cluster->connect("simplex");
$schema = $session->schema();
$id = $schema->keyspace("simplex")->table("values")->column("id");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd reduce this duplication by using something like $values = $schema->keyspace("simplex")->table("values")

@avalanche123
Copy link
Contributor

overall looks good, except for the 2 minor improvements I mentioned.
Do you think it is possible to still stick with cassandra-version-<number> style tags? They are actually processed and displayed in the docs - e.g. http://datastax.github.io/php-driver/features/batch_statements/#batch-statements

@mikefero
Copy link
Contributor Author

This is a little tricky, due to the way the schema metadata is not present for all C* versions. Let me think about a better way for the filter tags to keep the cassandra-version-<number> for the documentation. We will still need an only or greater suffix tag before the version designation though in order to allow all the schema properties to work correctly. The reason I mention suffix is Behat will short circuit matching on filter tags.

Are you against multiple tags for a Feature and/or Scenario?

@avalanche123
Copy link
Contributor

Multiple tags are fine

avalanche123
avalanche123 reviewed Sep 11, 2015
View reviewed changes
features/schema_metadata.feature

@cassandra-version-less-2.1
Scenario: Additional table metadata will only exist for Cassandra versions
1.2 and v2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.2 and 2.0 or v1.2 and v2.0

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.2 and 2.x ? :)

avalanche123 added a commit that referenced this pull request Sep 11, 2015
@avalanche123
Merge pull request #52 from datastax/php-22-test
8e76f7d 
[PHP-22] Schema Metadata Feature and Miscellaneous Windows Fixes
@avalanche123 avalanche123 merged commit 8e76f7d into master Sep 11, 2015
@avalanche123 avalanche123 deleted the php-22-test branch September 11, 2015 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikefero @avalanche123 @jippi