Allowing to configure custom headers for Total and Per-Page #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # ... | ||
| ``` | ||
|
|
||
|
|
There was a problem hiding this comment.
Can you fix up this extra line break?
|
@davidcelis thank you for your fast feedback and code review =) |
|
Looking good now! Thanks! Could you squash the commits before I merge this PR in? |
- not always we want to have the Total and Per-Page headers with that name, we may want to have a custom one like: X-Total-Count or X-Per-Page. - if nothing is configured it defaults to Total and Per-Page as the gem already did. Removing extra line break Changing to :attr_writer, since we already define the readers Aligning equal signs Adjusting the expected Header on test name
davidcelis
added a commit
that referenced
this pull request
Jan 23, 2015
Allowing to configure custom headers for Total and Per-Page
|
Thanks again!! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name, we may want to have a custom one like: X-Total-Count or
X-Per-Page.
already did.
Merged with the other pull requests that caused conflicts.