Remove warnings if user has explicitly defined paginator

[eidge]

This PR defers warnings to the first time ApiPagination.configuration.paginator is called.

This way no warnings will be generated if someone has explicitly defined a paginator even though more than one might be present.

[davidcelis]

This looks good; thanks! Would you mind squashing your two commits before I merge?

[eidge]

Done, thanks ;)

Hugo Ribeira

Jack of All Trades at *intoCros http://intocross.coms
http://intocross.com *
Tel: +351 910982209 http://910982209 * LinkedIn
http://pt.linkedin.com/pub/hugo-ribeira/45/295/536/ * GitHub
https://github.com/eidge
Universidade de Coimbra

2015-02-09 19:58 GMT+00:00 David Celis [email protected]:

This looks good; thanks! Would you mind squashing your two commits before
I merge?

—
Reply to this email directly or view it on GitHub
#36 (comment)
.

[sdsantos]

@davidcelis can you bump the gem version? Would love to avoid the warning :)

[davidcelis]

Hmmm. There’s one thing I’m still thinking about, which is that there’s still a possibility of someone including api-pagination without including kaminari or will_paginate. Now no warning is printed until, most likely, someone hits an endpoint that tries to paginate. Then the warning would be printed and they would immediately get exceptions. I’d rather that warning appear on booting the application, but I’m trying to figure out a good way to separate that warning from the “less important” warning.

[eidge]

One could run an extra verification that checks whether both kaminari and
will_paginate are undefined. Which should be way more rare and dangerous
than having both. What do you think?

Hugo Ribeira

Jack of All Trades at *intoCros http://intocross.coms
http://intocross.com *
Tel: +351 910982209 http://910982209 * LinkedIn
http://pt.linkedin.com/pub/hugo-ribeira/45/295/536/ * GitHub
https://github.com/eidge
Universidade de Coimbra

2015-02-11 17:24 GMT+00:00 David Celis [email protected]:

Hmmm. There’s one thing I’m still thinking about, which is that there’s
still a possibility of someone including api-pagination without including
kaminari or will_paginate. Now no warning is printed until, most likely,
someone hits an endpoint that tries to paginate. Then the warning would be
printed and they would immediately get exceptions. I’d rather that
warning appear on booting the application, but I’m trying to figure out a
good way to separate that warning from the “less important” warning.

—
Reply to this email directly or view it on GitHub
#36 (comment)
.

[davidcelis]

I’m okay with what this latest commit does. Let me know if y’all have thoughts before I release.

[eidge]

Yup seems fine, the warning should not fire anymore unless both gems are present and none explicitly defined but still fires if none is present at start up time. Right?

The version bump is still necessary to update te the gem though, is it not?

Thanks for the support :)

[davidcelis]

Yep, I’ll bump the version in a bit

[davidcelis]

I’ve released versions 3.2.1 and 4.1.1.