Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sequel orm has it's own
#pagination
method.will_paginate
doesn't override or wrap this method, it instead just uses the built in sequel pagination method. However, sequel's#paginate
has a different method signature, instead of a hash or named parameters, it looks like this:I couldn't think of a cleaner way to support Sequel, so what it does is check to see if
collections
inherits fromSequel::Dataset
and if it does, it'll call#paginate
with Sequel's method signature. If you have a better way to implement this, let me know and I'll do my best to modify this PR.