-
Notifications
You must be signed in to change notification settings - Fork 80
feat: init TypeScript Ragbits API Client modules #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments to be addressed.
I am also thinking about renaming the typescript
directory to something more descriptive. Maybe client
would be good? WDYT?
typescript/ui/src/contexts/HistoryContext/HistoryContextProvider.tsx
Outdated
Show resolved
Hide resolved
Trivy scanning results. Report Summary ┌───────────────────────────────────────────────────────┬──────┬─────────────────┬─────────┐
For OSS Maintainers: VEX NoticeIf you're an OSS maintainer and Trivy has detected vulnerabilities in your project that you believe are not actually exploitable, consider issuing a VEX (Vulnerability Exploitability eXchange) statement. To disable this notice, set the TRIVY_DISABLE_VEX_NOTICE environment variable. uv.lock (uv)Total: 16 (MEDIUM: 8, HIGH: 6, CRITICAL: 2) ┌──────────────┬────────────────┬──────────┬────────┬───────────────────┬───────────────┬──────────────────────────────────────────────────────────────┐ |
Code Coverage Summary
Diff against main
Results for commit: f0c7894 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor nits. Looks good overall.
typescript/ui/src/contexts/HistoryContext/HistoryContextProvider.tsx
Outdated
Show resolved
Hide resolved
…:deepsense-ai/ragbits into jd/typescript-ragbits-api-client-modules
No description provided.