error on two joiner words

[daryanypl]

If a name contains two joiner words one after another, s.a. "John of the Doe", get:
HumanName:ERROR:parser.py:Couldn't find 'The' in pieces.
error.

[derek73]

I cannot replicate this. Could you provide more information to help me replicate?

$ python tests.py "John of the Doe"
<HumanName : [
    title: '' 
    first: 'John of the Doe' 
    middle: '' 
    last: '' 
    suffix: ''
    nickname: ''
]>
$ python tests.py "John of The Doe"
<HumanName : [
    title: '' 
    first: 'John of The Doe' 
    middle: '' 
    last: '' 
    suffix: ''
    nickname: ''
]>

[daryanypl]

Sure.

from nameparser import HumanName

def test_name(name):
HumanName('Bob, Author of The book of the allies')

I've played around a bit, and it's not all "of the" combinations. For
example,

HumanName('Bob, Author of the book of the allies')
and
HumanName('Bob, Author of The book on allies')
are both fine.

Darya

On Wed, Aug 3, 2016 at 3:58 PM, derek73 notifications@github.com wrote:

I cannot replicate this. Could you provide more information to help me
replicate?

$ python tests.py "John of the Doe"
title: ''
first: 'John of the Doe'
middle: ''
last: ''
suffix: ''
nickname: ''
]>
$ python tests.py "John of The Doe"
title: ''
first: 'John of The Doe'
middle: ''
last: ''
suffix: ''
nickname: ''
]>

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#53 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARcioqvk2I-s9evLOAItsFtAA1yePI3Iks5qcPLygaJpZM4Jb0Zl
.

[derek73]

'Bob, Author of the book of the allies' doesn't give the error, so I think it's related to capitalization of multiple conjunctions when combined with titles. Should be parsed as a title though. That join_on_conjunctions() part of the parse code makes my head melt but I'll poke around and see if I can figure it out.

$ python tests.py "Bob, Author of the book of the allies"
<HumanName : [
    title: '' 
    first: 'Author of the book of the allies' 
    middle: '' 
    last: 'Bob' 
    suffix: ''
    nickname: ''
]>

[daryanypl]

Happy to help test.

Darya

On Wed, Aug 3, 2016 at 7:45 PM, derek73 notifications@github.com wrote:

'Bob, Author of the book of the allies' doesn't give the error, so I think
it's related to capitalization of multiple conjunctions when combined with
titles. Should be parsed as a title though. That join_on_conjunctions()
part of the parse code makes my head melt but I'll poke around and see if I
can figure it out.

$ python tests.py "Bob, Author of the book of the allies"
<HumanName : [
title: ''
first: 'Author of the book of the allies'
middle: ''
last: 'Bob'
suffix: ''
nickname: ''
]>

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#53 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARciouwdP9JqKWFWEucfHcl-6Lqm0kDmks5qcSgDgaJpZM4Jb0Zl
.

[derek73]

I ended up refactoring that join_on_conjunctions() method entirely because, even though I wrote it, I couldn't understand it. It was one of those "I guess it works so don't fix it" things. But now I think I've got it fixed, all the test are passing.

It's in master now. I think you can install it with pip install -e git+git://github.com/derek73/python-nameparser.git@v0.5.0-beta#egg=nameparser. I also made pre-release v0.5.0-beta if that's easier. Give a try and let me know if you run into any issues.

[derek73]

I'm going to go ahead and close this ticket and make a new release. Let me know if you have any problems with it.

[daryanypl]

Thanks, and sorry for the delay. Verified that "of the of the" no longer throws an error. Found a few more interesting special cases. Filed here: #57 . Darya

…

On Wed, Aug 10, 2016 at 4:59 PM, derek73 ***@***.***> wrote: Closed #53 <#53>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#53 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARciotuBN8QVXyEicR-q9_nJf4U_6klrks5qejuogaJpZM4Jb0Zl> .