Skip to content

Avoid use of sys.version for checking Python version #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2018

Conversation

svisser
Copy link
Contributor

@svisser svisser commented Oct 3, 2017

This changes the Python 2 / 3 version check to use sys.version_info as the version number is not guaranteed to be at the beginning of sys.version across Python implementations. Please also see the note in the documentation: https://docs.python.org/2/library/sys.html#sys.version.

@svisser
Copy link
Contributor Author

svisser commented Oct 3, 2017

The build fails but that's due to no such option: --use-mirrors when calling pip, not this code change.

@derek73 derek73 merged commit 29727b9 into derek73:master Jan 15, 2018
@svisser svisser deleted the py3_version_info branch January 15, 2018 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants