Skip to content

fix: don't cast scopes as an array #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2018
Merged

fix: don't cast scopes as an array #16

merged 1 commit into from
Oct 3, 2018

Conversation

willtj
Copy link
Contributor

@willtj willtj commented Oct 3, 2018

Because it's already an array when it comes back from MongoDB - accessing $token->scopes without this change throws an error because it's trying to cast from a MySQL json-encoded array

json_decode() expects parameter 1 to be string, array given

Because it's already an array when it comes back from MongoDB - accessing `$token->scopes` without this change throws an error because it's trying to cast from a MySQL json-encoded array
```
json_decode() expects parameter 1 to be string, array given
```
@willtj willtj requested a review from StevePorter92 October 3, 2018 11:09
Copy link
Contributor

@StevePorter92 StevePorter92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants