Skip to content

Adding Azure SQL Database templates #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

croblesm
Copy link
Contributor

What type of PR is this?

  • Add a new dev container collection
  • Update to an existing dev container collection
  • Documentation/spec update
  • Other containers.dev site update (UX, layout, etc)

Description

Hello there 👋

With this PR, I'm updating collection-index.yml file to include the Azure SQL Database templates. The main repo can be found here.

I have been working with @samruddhikhandale and @bamurtaugh on this project.

Collection checklist

If your PR contributes a new collection, please utilize this checklist:

  • Collection name
  • Maintainer name
  • Maintainer contact link (i.e. link to a GitHub repo, email)
  • Repository URL
  • OCI Reference
  • I acknowledge that this collection provides new functionality, distinct from the existing collections part of this index.

Updating collection-index.yml file, adding Azure SQL Database templates.
@croblesm croblesm requested a review from a team as a code owner June 24, 2024 21:06
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@samruddhikhandale samruddhikhandale merged commit eb45190 into devcontainers:gh-pages Jun 25, 2024
1 check passed
Comment on lines +11 to +15
- name: Azure SQL Database Dev Container Templates
maintainer: Azure SQL Developer Experiences Team
contact: https://github.com/microsoft/azuresql-devcontainers/issues
repository: https://github.com/microsoft/azuresql-devcontainers
ociReference: ghcr.io/microsoft/azuresql-devcontainers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: why was this added in this position instead of at the end?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samruddhikhandale Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants