Skip to content

Commit f6dfe2d

Browse files
authored
Merge pull request #81 from jreiberkyle/preview-offset-arg-79
preview: make tiles subdir and provide default for imagery_offset arg
2 parents 94f1863 + 2579fff commit f6dfe2d

File tree

4 files changed

+11
-10
lines changed

4 files changed

+11
-10
lines changed

label_maker/images.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,12 +66,12 @@ def class_test(value):
6666

6767
# download tiles
6868
tiles = class_tiles + background_tiles
69-
print('Downloading {} tiles to {}'.format(len(tiles), op.join(dest_folder, 'tiles')))
69+
print('Downloading {} tiles to {}'.format(len(tiles), tiles_dir))
7070

7171
# get image acquisition function based on imagery string
7272
image_function = download_tile_tms
7373
if is_tif(imagery):
7474
image_function = get_tile_tif
7575

7676
for tile in tiles:
77-
image_function(tile, imagery, dest_folder, imagery_offset)
77+
image_function(tile, imagery, tiles_dir, imagery_offset)

label_maker/preview.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
from label_maker.utils import class_match, download_tile_tms, get_tile_tif, is_tif
1111

12-
def preview(dest_folder, number, classes, imagery, ml_type, imagery_offset, **kwargs):
12+
def preview(dest_folder, number, classes, imagery, ml_type, imagery_offset=False, **kwargs):
1313
"""Produce imagery examples for specified classes
1414
1515
Parameters
@@ -55,6 +55,7 @@ def preview(dest_folder, number, classes, imagery, ml_type, imagery_offset, **kw
5555
for i, cl in enumerate(classes):
5656
# create class directory
5757
class_dir = op.join(dest_folder, 'examples', cl.get('name'))
58+
5859
if not op.isdir(class_dir):
5960
makedirs(class_dir)
6061

label_maker/utils.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,16 @@ def class_match(ml_type, label, i):
2424
return np.count_nonzero(label == i)
2525
return None
2626

27-
def download_tile_tms(tile, imagery, dest_folder, *args):
27+
def download_tile_tms(tile, imagery, folder, *args):
2828
"""Download a satellite image tile from a tms endpoint"""
2929
o = urlparse(imagery)
3030
_, image_format = op.splitext(o.path)
3131
r = requests.get(url(tile.split('-'), imagery))
32-
tile_img = op.join(dest_folder, 'tiles', '{}{}'.format(tile, image_format))
32+
tile_img = op.join(folder, '{}{}'.format(tile, image_format))
3333
open(tile_img, 'wb').write(r.content)
3434
return tile_img
3535

36-
def get_tile_tif(tile, imagery, dest_folder, imagery_offset):
36+
def get_tile_tif(tile, imagery, folder, imagery_offset):
3737
"""
3838
Read a GeoTIFF with a window corresponding to a TMS tile
3939
@@ -80,7 +80,7 @@ def get_tile_tif(tile, imagery, dest_folder, imagery_offset):
8080
src.read(k, window=window, out=data[k - 1], boundless=True)
8181

8282
# save
83-
tile_img = op.join(dest_folder, 'tiles', '{}{}'.format(tile, '.jpg'))
83+
tile_img = op.join(folder, '{}{}'.format(tile, '.jpg'))
8484
img = Image.fromarray(np.moveaxis(data, 0, -1), mode='RGB')
8585
img.save(tile_img)
8686

test/unit/test_utils.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ def test_get_tile_tif(self):
5252
if not op.isdir(tiles_dir):
5353
makedirs(tiles_dir)
5454

55-
get_tile_tif(tile, 'test/fixtures/drone.tif', dest_folder, None)
55+
get_tile_tif(tile, 'test/fixtures/drone.tif', tiles_dir, None)
5656
test_tile = Image.open('test/tiles/{}.jpg'.format(tile))
5757
fixture_tile = Image.open('test/fixtures/{}.jpg'.format(tile))
5858
self.assertEqual(test_tile, fixture_tile)
@@ -66,7 +66,7 @@ def test_get_tile_tif_offset(self):
6666
if not op.isdir(tiles_dir):
6767
makedirs(tiles_dir)
6868

69-
get_tile_tif(tile, 'test/fixtures/drone.tif', dest_folder, [128, 64])
69+
get_tile_tif(tile, 'test/fixtures/drone.tif', tiles_dir, [128, 64])
7070
test_tile = Image.open('test/tiles/{}.jpg'.format(tile))
7171
fixture_tile = Image.open('test/fixtures/{}_offset.jpg'.format(tile))
7272
self.assertEqual(test_tile, fixture_tile)
@@ -80,7 +80,7 @@ def test_get_tile_vrt(self):
8080
if not op.isdir(tiles_dir):
8181
makedirs(tiles_dir)
8282

83-
get_tile_tif(tile, 'test/fixtures/drone.vrt', dest_folder, None)
83+
get_tile_tif(tile, 'test/fixtures/drone.vrt', tiles_dir, None)
8484
test_tile = Image.open('test/tiles/{}.jpg'.format(tile))
8585
fixture_tile = Image.open('test/fixtures/{}.jpg'.format(tile))
8686
self.assertEqual(test_tile, fixture_tile)

0 commit comments

Comments
 (0)