Skip to content

preview: make tiles subdir and provide default for imagery_offset arg #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 11, 2018

Conversation

jreiberkyle
Copy link
Contributor

@jreiberkyle jreiberkyle commented May 4, 2018

Two fixes to make preview cli command run successfully:

  1. provide default value of False for imagery_offset
  2. create tiles subdir in example directories for download functions to populate with tiles

Closes #79

@drewbo
Copy link
Contributor

drewbo commented May 4, 2018

Thanks @jreiberkyle; default looks good. Instead of adding the tiles directory, can we instead update the two download functions to not hardcode that and instead pass it as the folder parameter?

Happy to update if you're busy with something else

@jreiberkyle
Copy link
Contributor Author

yeah @drewbo , that solution sounds great! Go ahead and make changes to this as you see fit.

@drewbo
Copy link
Contributor

drewbo commented May 7, 2018

@jreiberkyle I made the updates at https://github.com/developmentseed/label-maker/tree/preview-offset-arg-79. I can merge from there, or push those same commits to your branch if you give me edit access to this PR.

@jreiberkyle
Copy link
Contributor Author

@drewbo nice! I believe you have access to this PR already (the little checkbox next to "Allow edits from maintainers" is checked). Will that work or do you need write access to the branch on my fork?

@drewbo
Copy link
Contributor

drewbo commented May 11, 2018

@jreiberkyle you were right and I already had access; I was trying to push to your branch with the wrong method so I was getting a permissions error (https vs. ssh)

@drewbo drewbo merged commit f6dfe2d into developmentseed:master May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preview fails with: missing 1 required positional argument: 'imagery_offset'
2 participants