Add abs paths to allow label-maker cli to work outside module dir #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbo
suggested changes
Jan 11, 2018
label_maker/main.py
Outdated
| def parse_args(args): | ||
| """Create an argument parser with subcommands""" | ||
| desc = 'label_maker (v%s)' % __version__ | ||
| dhf = argparse.ArgumentDefaultsHelpFormatter | ||
| parser = argparse.ArgumentParser(description=desc) | ||
| config_fpath = op.join(op.dirname(__file__), '..', 'config.json') |
There was a problem hiding this comment.
@wronk can we leave this one as is? The default config should be relative to the users directory and not the module
|
@wronk looks solid; can you add a test just to verify this won't fail again? |
wronk
force-pushed
the
bug/2-pwd
branch
4 times, most recently
from
ec78d73 to
b0d8024
Compare
drewbo
approved these changes
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2