-
Notifications
You must be signed in to change notification settings - Fork 111
fix image and tile format inconsistency #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When a local GeoTIFF or a remote Cloud Optimized GeoTIFF is provided, the image tiles are generated in jpg format. Therefore, the `label-maker package` should look for image tiles in jpg format rather than tif format.
@drewbo Thanks a lot for adding support for GeoTIFF reading!! I tested the new version using a local GeoTIFF, everything worked fine except the |
Thanks @giswqs we definitely overlooked this. Could you add a test case for this situation to test/integration folder? I can give some assistance setting that up if you need |
@drewbo This is my first-time learning and using unittest. Feel free to discard my changes if it is the not right way. Added files: What I did:
|
@giswqs thanks! This is almost there. Because all our tests run automatically on CircleCI, we need to have the images already present. We already have a very small portion of this tif present in the |
@drewbo Thanks for your guidance! I have changed the bounding box (4 tiles with zoom level 20) and added |
Thanks @giswqs! |
When a local GeoTIFF or a remote Cloud Optimized GeoTIFF is provided, the image tiles are generated in jpg format. Therefore, the
label-maker package
command should look for image tiles in jpg format rather than tif format.