Skip to content

docs: revamp object customization docs #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 14, 2024
Merged

Conversation

shivansh
Copy link
Contributor

@shivansh shivansh requested a review from a team as a code owner October 11, 2024 07:16
Copy link
Contributor

github-actions bot commented Oct 11, 2024

🌟 EkLine Reviewer

Hello! I’m here to help improve your docs. I’ve reviewed your pull request, and left in-line suggestions for quick fixes. For details, visit the Analytics Page.

For questions or feedback, please email [email protected].

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor


## Concepts
Subtypes are categories of DevRev object types. They inherit all fields from the parent
type and can include additional, specific fields. For example, an "Incident" subtype of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest italics for types like this.

Suggested change
type and can include additional, specific fields. For example, an "Incident" subtype of
type and can include additional, specific fields. For example, an _Incident_ subtype of

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor


## Concepts
Subtypes are kinds of DevRev object types. They inherit all fields from the parent type

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Subtypes are kinds of DevRev object types. They inherit all fields from the parent type
Subtypes are flavors of DevRev object types. They inherit all fields from the parent type

Copy link
Contributor Author

@shivansh shivansh Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally didn't use "flavor" here because it is informal. I was confused between "subtype being a kind of an object type" or "subtype categorising the object type" — turns out it's the former:

A "category" implies a group that contains multiple types, so an
animal category would include mammals, birds, reptiles, etc. A "kind"
refers to a specific type or instance within a category. In this
context, humans are a kind of animal (within the mammalian category)
rather than a separate category of animals.

I do use "bug-flavored issue" further down the doc.

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

@shivansh shivansh merged commit 3dfd1ef into main Oct 14, 2024
3 checks passed
@shivansh shivansh deleted the shivansh/customization-docs branch October 14, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants