Skip to content

ADaaS revision #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 6, 2024
Merged

ADaaS revision #113

merged 9 commits into from
Dec 6, 2024

Conversation

bc-devrev
Copy link
Contributor

@bc-devrev bc-devrev requested a review from a team as a code owner November 18, 2024 20:23
Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Copy link
Contributor

@erazemk erazemk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit about the Mermaid Markdown color scheme, besides that LGTM.

Comment on lines 10 to 45
```mermaid
flowchart TD
%%{
init: {
'theme': 'base',
'themeVariables': {
'fontFamily': 'Segoe UI',
'lineColor': '#000',
'primaryTextColor': 'white',
'primaryColor': '#2a33ff',
'primaryBorderColor': '#62D65D',
'secondaryColor': '#5D0E1C',
'tertiaryColor': '#e6e6e6',
'clusterBorder': 'white'
}
}
}%%
externalSystem[External system]
worker([Worker])
s3interact[s3interact]
airdrop[Airdrop]
s3[(AWS S3)]

externalSystem <-- Get/create users, issues, ... --> worker

worker <-- Exchange artifact upload/download URLs --> s3interact
worker <-- Upload/download artifacts --> s3
worker <-- ADaaS messages and REST API --> airdrop


subgraph DevRev
s3interact <-- Prepare upload/download URL --> s3
airdrop <-- Download/upload artifacts --> s3
end

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default color scheme seems non-pleasant, we need to find a better color scheme.
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just now saw you added an init function, why? Was the default color scheme not good enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This color scheme uses DevRev colors as specified in the Brand Guidelines. If you have a suggestion for a better way to apply those colors I'm open to it.

Copy link
Contributor

@erazemk erazemk Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see these exact colors in the Figma link you shared, but also, I think having the diagram nicely fit is probably preferable. If needed, we can ask one of the designers to choose a color scheme that would fit on this specific page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct about the colors. I now recall that I used the colors from some other diagram which, although it came from design, apparently didn't conform to the brand guidelines. I don't have time to mess around with it anymore so I have removed the color settings and just kept the font.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, IMO the default looks the best anyway. Thanks for the changes!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my review doesn't count anyway 😂

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Copy link
Contributor

github-actions bot commented Dec 5, 2024

@bc-devrev
Copy link
Contributor Author

@radovan-jorgic @samod let me know if you have any feedback; otherwise I will merge this change tomorrow.

@bc-devrev bc-devrev merged commit 2853ea7 into main Dec 6, 2024
2 checks passed
@bc-devrev bc-devrev deleted the bc/adaas-ISS-128134 branch December 6, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants