-
Notifications
You must be signed in to change notification settings - Fork 3
split platform push notification instructions #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🌟 EkLine ReviewerHello! I’m here to help improve your docs. I’ve reviewed your pull request, and left in-line suggestions for quick fixes. For details, visit the Analytics Page. For questions or feedback, please email [email protected]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
EkLine
🚫 [EkLine] reported by reviewdog 🐶
Keep one space between words and punctuation in 'v.I'. (EK00025)
|Resumes a paused session recording. |resumeRecording() |resumeRecording(DevRev.INSTANCE); | |
Consider using 'go' instead of 'navigate'. (EK25033)
The DevRev SDK offers automatic screen tracking to help you understand how users navigate through your app. Although activities are automatically tracked, you can manually track screens or fragments using the following method: |
Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
This method will generate and return the device token. |
📝 [EkLine] reported by reviewdog 🐶
Avoid using 'we' as it can come off as patronizing. For example, write 'The configuration is complete' rather than 'We are now done with the configuration.' (EK81039)
We recommend integrating the DevRev SDK using SPM. |
🚫 [EkLine] reported by reviewdog 🐶
'Swift Package Manager' should use sentence-style capitalization. (EK00037)
### Swift Package Manager |
Consider using 'go' instead of 'navigate'. (EK25033)
1. Open your project in Xcode and navigate to the **Add Package Dependency**. |
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- For SSH: `[email protected]:devrev/devrev-sdk-ios.git` |
Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
This will install the DevRev SDK in your project, making it ready for use. |
Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
The SDK will be ready for use once you execute the following configuration method. |
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- UIKit apps |
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- SwiftUI apps |
Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
If you haven't previously identified the user, the DevRev SDK will automatically create an anonymous user for you immediately after the SDK is configured. |
Consider using 'go' instead of 'navigate'. (EK25033)
The DevRev SDK offers automatic screen tracking to help you understand how users navigate through your app. Although view controllers are automatically tracked, you can manually track screens using the following method: |
📝 [EkLine] reported by reviewdog 🐶
Remove 'properly ' if it's not important to the meaning of the statement. (EK00006)
To properly handle push notifications, implement the following method, typically in either the `UNUserNotificationCenterDelegate.userNotificationCenter(_:didReceive:)` or `UIApplicationDelegate.application(_:didReceiveRemoteNotification:fetchCompletionHandler:)`: |
Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
- **Issue**: Support chat won't show. |
<Info> | ||
**Prerequisites** | ||
|
||
- Google Developer Account and Firebase project access |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- Google Developer Account and Firebase project access | |
- Google Developer Account and Firebase project access. |
**Prerequisites** | ||
|
||
- Google Developer Account and Firebase project access | ||
- Admin access to DevRev PLuG settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- Admin access to DevRev PLuG settings | |
- Admin access to DevRev PLuG settings. |
|
||
- Google Developer Account and Firebase project access | ||
- Admin access to DevRev PLuG settings | ||
- Access to Bundle ID, Team ID, and APNs/FCM keys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- Access to Bundle ID, Team ID, and APNs/FCM keys | |
- Access to Bundle ID, Team ID, and APNs/FCM keys. |
- Google Developer Account and Firebase project access | ||
- Admin access to DevRev PLuG settings | ||
- Access to Bundle ID, Team ID, and APNs/FCM keys | ||
- Mobile SDK integration with your Android app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- Mobile SDK integration with your Android app | |
- Mobile SDK integration with your Android app. |
<Info> | ||
**Prerequisites** | ||
|
||
- Apple Developer Program access |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- Apple Developer Program access | |
- Apple Developer Program access. |
**Prerequisites** | ||
|
||
- Apple Developer Program access | ||
- Admin access to DevRev PLuG settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- Admin access to DevRev PLuG settings | |
- Admin access to DevRev PLuG settings. |
|
||
- Apple Developer Program access | ||
- Admin access to DevRev PLuG settings | ||
- Access to Bundle ID, Team ID, and APNs/FCM keys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- Access to Bundle ID, Team ID, and APNs/FCM keys | |
- Access to Bundle ID, Team ID, and APNs/FCM keys. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- Android Studio 2022.1.1 or later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- Android Gradle plugin version 7.4 or later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- Gradle version 7.6 or later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- Minimum Android SDK 24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
DevRev.configure(context: Context, appId: String) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Published docs preview URL: https://devrev-preview-cf0e7889-b501-4d00-9757-569d840f1c52.docs.buildwithfern.com |
No description provided.