Skip to content

split platform push notification instructions #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

bc-devrev
Copy link
Contributor

No description provided.

@bc-devrev bc-devrev requested a review from a team as a code owner April 3, 2025 21:22
Copy link
Contributor

github-actions bot commented Apr 3, 2025

🌟 EkLine Reviewer

Hello! I’m here to help improve your docs. I’ve reviewed your pull request, and left in-line suggestions for quick fixes. For details, visit the Analytics Page.

For questions or feedback, please email [email protected].

@bc-devrev bc-devrev requested review from bojan and rohan-devrev April 3, 2025 21:23
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

EkLine

🚫 [EkLine] reported by reviewdog 🐶

Keep one space between words and punctuation in 'v.I'. (EK00025)

|Resumes a paused session recording. |resumeRecording() |resumeRecording(DevRev.INSTANCE); |


⚠️ [EkLine] reported by reviewdog 🐶

Consider using 'go' instead of 'navigate'. (EK25033)

The DevRev SDK offers automatic screen tracking to help you understand how users navigate through your app. Although activities are automatically tracked, you can manually track screens or fragments using the following method:


⚠️ [EkLine] reported by reviewdog 🐶

Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)

This method will generate and return the device token.


📝 [EkLine] reported by reviewdog 🐶

Avoid using 'we' as it can come off as patronizing. For example, write 'The configuration is complete' rather than 'We are now done with the configuration.' (EK81039)

We recommend integrating the DevRev SDK using SPM.


🚫 [EkLine] reported by reviewdog 🐶

'Swift Package Manager' should use sentence-style capitalization. (EK00037)

### Swift Package Manager


⚠️ [EkLine] reported by reviewdog 🐶

Consider using 'go' instead of 'navigate'. (EK25033)

1. Open your project in Xcode and navigate to the **Add Package Dependency**.


🚫 [EkLine] reported by reviewdog 🐶

Must put the ending punctuation at the end of a list item. (EK00041)

- For SSH: `[email protected]:devrev/devrev-sdk-ios.git`


⚠️ [EkLine] reported by reviewdog 🐶

Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)

This will install the DevRev SDK in your project, making it ready for use.


⚠️ [EkLine] reported by reviewdog 🐶

Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)

The SDK will be ready for use once you execute the following configuration method.


🚫 [EkLine] reported by reviewdog 🐶

Must put the ending punctuation at the end of a list item. (EK00041)


🚫 [EkLine] reported by reviewdog 🐶

Must put the ending punctuation at the end of a list item. (EK00041)


⚠️ [EkLine] reported by reviewdog 🐶

Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)

If you haven't previously identified the user, the DevRev SDK will automatically create an anonymous user for you immediately after the SDK is configured.


⚠️ [EkLine] reported by reviewdog 🐶

Consider using 'go' instead of 'navigate'. (EK25033)

The DevRev SDK offers automatic screen tracking to help you understand how users navigate through your app. Although view controllers are automatically tracked, you can manually track screens using the following method:


📝 [EkLine] reported by reviewdog 🐶

Remove 'properly ' if it's not important to the meaning of the statement. (EK00006)

To properly handle push notifications, implement the following method, typically in either the `UNUserNotificationCenterDelegate.userNotificationCenter(_:didReceive:)` or `UIApplicationDelegate.application(_:didReceiveRemoteNotification:fetchCompletionHandler:)`:


⚠️ [EkLine] reported by reviewdog 🐶

Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)

- **Issue**: Support chat won't show.

<Info>
**Prerequisites**

- Google Developer Account and Firebase project access
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] reported by reviewdog 🐶

Must put the ending punctuation at the end of a list item. (EK00041)

Suggested change
- Google Developer Account and Firebase project access
- Google Developer Account and Firebase project access.

**Prerequisites**

- Google Developer Account and Firebase project access
- Admin access to DevRev PLuG settings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] reported by reviewdog 🐶

Must put the ending punctuation at the end of a list item. (EK00041)

Suggested change
- Admin access to DevRev PLuG settings
- Admin access to DevRev PLuG settings.


- Google Developer Account and Firebase project access
- Admin access to DevRev PLuG settings
- Access to Bundle ID, Team ID, and APNs/FCM keys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] reported by reviewdog 🐶

Must put the ending punctuation at the end of a list item. (EK00041)

Suggested change
- Access to Bundle ID, Team ID, and APNs/FCM keys
- Access to Bundle ID, Team ID, and APNs/FCM keys.

- Google Developer Account and Firebase project access
- Admin access to DevRev PLuG settings
- Access to Bundle ID, Team ID, and APNs/FCM keys
- Mobile SDK integration with your Android app
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] reported by reviewdog 🐶

Must put the ending punctuation at the end of a list item. (EK00041)

Suggested change
- Mobile SDK integration with your Android app
- Mobile SDK integration with your Android app.

<Info>
**Prerequisites**

- Apple Developer Program access
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] reported by reviewdog 🐶

Must put the ending punctuation at the end of a list item. (EK00041)

Suggested change
- Apple Developer Program access
- Apple Developer Program access.

**Prerequisites**

- Apple Developer Program access
- Admin access to DevRev PLuG settings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] reported by reviewdog 🐶

Must put the ending punctuation at the end of a list item. (EK00041)

Suggested change
- Admin access to DevRev PLuG settings
- Admin access to DevRev PLuG settings.


- Apple Developer Program access
- Admin access to DevRev PLuG settings
- Access to Bundle ID, Team ID, and APNs/FCM keys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] reported by reviewdog 🐶

Must put the ending punctuation at the end of a list item. (EK00041)

Suggested change
- Access to Bundle ID, Team ID, and APNs/FCM keys
- Access to Bundle ID, Team ID, and APNs/FCM keys.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] reported by reviewdog 🐶

Must put the ending punctuation at the end of a list item. (EK00041)

- Android Studio 2022.1.1 or later

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] reported by reviewdog 🐶

Must put the ending punctuation at the end of a list item. (EK00041)

- Android Gradle plugin version 7.4 or later

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] reported by reviewdog 🐶

Must put the ending punctuation at the end of a list item. (EK00041)

- Gradle version 7.6 or later

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] reported by reviewdog 🐶

Must put the ending punctuation at the end of a list item. (EK00041)

- Minimum Android SDK 24

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [EkLine] reported by reviewdog 🐶

Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)

2. After obtaining the credentials, you can configure the DevRev SDK in your app. The SDK will be ready for use once you execute the configuration method.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] reported by reviewdog 🐶

Must put the ending punctuation at the end of a list item. (EK00041)

DevRev.configure(context: Context, appId: String)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] reported by reviewdog 🐶

Don't use language (such as 'disabled ') that defines people by their disability. (EK00030)

If session recording was disabled for the user using the `stopAllMonitoring()` method, you can enable recording at runtime with this method.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] reported by reviewdog 🐶

Keep one space between words and punctuation in 'v.I'. (EK00025)

|Starts the session recording. |startRecording() |startRecording(DevRev.INSTANCE, context); |

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] reported by reviewdog 🐶

Keep one space between words and punctuation in 'v.I'. (EK00025)

|Ends the session recording and uploads it to the portal. |stopRecording() |stopRecording(DevRev.INSTANCE); |

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] reported by reviewdog 🐶

Keep one space between words and punctuation in 'v.I'. (EK00025)

|Pauses the ongoing session recording. |pauseRecording() |pauseRecording(DevRev.INSTANCE); |

Copy link
Contributor

github-actions bot commented Apr 3, 2025

@bc-devrev bc-devrev closed this Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant