-
Notifications
You must be signed in to change notification settings - Fork 3
ISS-160256: Restructure the SDK documentation for iOS #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISS-160256: Restructure the SDK documentation for iOS #215
Conversation
🌟 EkLine ReviewerHello! I’m here to help improve your docs. I’ve reviewed your pull request, and left in-line suggestions for quick fixes. For details, visit the Analytics Page. For questions or feedback, please email [email protected]. |
Published docs preview URL: https://devrev-preview-a96ff0da-5ffb-4bad-8c04-17358ce58a82.docs.buildwithfern.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the content in this page is too much for one page. The structure starts to break down pretty early. Is it possible to move some of it to another page?
You could also try the stylecheck utility which is experimental.
fern/docs/pages/plug-sdk/ios.mdx
Outdated
**Solution**: Ensure you have correctly called one of the identification methods: `DevRev.identifyUnverifiedUser(...)` or `DevRev.identifyAnonymousUser(...)`. | ||
|
||
- **Issue**: Not receiving push notifications. | ||
- **Issue**: Not receiving push notifications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- **Issue**: Not receiving push notifications. | |
- **Issue**: Users do not receive push notifications. |
@@ -1,12 +1,13 @@ | |||
This section describes the process of integrating the DevRev SDK with your iOS app. | |||
|
|||
## Requirements | |||
## Quickstart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend against this. It doesn't look all that "quick" to me. "Integration" seems like a more suitable term, but that's used in the section that has SPM and CocoaPods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll split it in the next iteration into sub-pages.
|
||
- Xcode 16.0 or higher (latest stable version available on the App Store). | ||
- Swift 5.9 or later. | ||
- Set the minimum deployment target for your iOS application as iOS 15. | ||
|
||
## Integration | ||
### Integration | ||
|
||
The DevRev SDK can be integrated using either Swift Package Manager (SPM) or CocoaPods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SPM and CocoaPods sections aren't nested properly. They'd need to be H4, which isn't recommended. An accordion group or tabs might be a better option for those sections.
fern/docs/pages/plug-sdk/ios.mdx
Outdated
@@ -175,6 +202,13 @@ To display the support chat screen in a SwiftUI app, you can use the following v | |||
DevRev.supportView | |||
``` | |||
|
|||
#### Creating a new conversation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't have H4.
- UIKit apps | ||
|
||
Configure the SDK in the `AppDelegate.application(_:didFinishLaunchingWithOptions:)` method. | ||
|
||
- SwiftUI apps | ||
|
||
Depending on your app's architecture, configure the SDK at the app's entry point or initial view. | ||
|
||
## Identification | ||
## Features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure of the purpose of calling a list of stuff "Features". I'm also not sure if everything in this group is really a feature.
## Features | |
## Features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are all features of the SDK and they will get split into sub-pages in the next iteration.
**Solution**: Double-check the setup process and ensure that `DevRevSDK` is correctly linked to your application. | ||
|
||
- **Issue**: How does the DevRev SDK handle errors? | ||
- **Issue**: How does the DevRev SDK handle errors? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is important information to include but doesn't belong here. I'd suggest moving it up to the "Quickstart" section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The troubleshooting will go into a sub-page in the next iteration.
Published docs preview URL: https://devrev-preview-47b977fb-3eb1-4d47-bca1-13d1cfc957d1.docs.buildwithfern.com |
@@ -1,12 +1,13 @@ | |||
This section describes the process of integrating the DevRev SDK with your iOS app. | |||
|
|||
## Requirements | |||
## Quickstart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll split it in the next iteration into sub-pages.
pod 'DevRevSDK', '~> 1.0.0' | ||
``` | ||
2. Run `pod install` in your project directory. | ||
</Tab> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not leave blank lines before the closing tab (for both cases).
- UIKit apps | ||
|
||
Configure the SDK in the `AppDelegate.application(_:didFinishLaunchingWithOptions:)` method. | ||
|
||
- SwiftUI apps | ||
|
||
Depending on your app's architecture, configure the SDK at the app's entry point or initial view. | ||
|
||
## Identification | ||
## Features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are all features of the SDK and they will get split into sub-pages in the next iteration.
**Solution**: Double-check the setup process and ensure that `DevRevSDK` is correctly linked to your application. | ||
|
||
- **Issue**: How does the DevRev SDK handle errors? | ||
- **Issue**: How does the DevRev SDK handle errors? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The troubleshooting will go into a sub-page in the next iteration.
DevRev.logout(deviceID:) | ||
``` | ||
|
||
The user will be logged out by clearing their credentials, as well as unregistering the device from receiving push notifications, and stopping the session recording. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
The user will be logged out by clearing their credentials, as well as unregistering the device from receiving push notifications, and stopping the session recording. | |
The user is logged out by clearing their credentials, as well as unregistering the device from receiving push notifications, and stopping the session recording. |
@@ -175,7 +203,14 @@ To display the support chat screen in a SwiftUI app, you can use the following v | |||
DevRev.supportView | |||
``` | |||
|
|||
#### New conversation closure | |||
### Creating a new conversation | |||
You have the ability to create a new conversation from within your app. The method will show the support chat screen and create a new conversation at the same time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
You have the ability to create a new conversation from within your app. The method will show the support chat screen and create a new conversation at the same time. | |
You have the ability to create a new conversation from within your app. The method shows the support chat screen and creates a new conversation at the same time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Published docs preview URL: https://devrev-preview-863ec4b6-69bd-4300-9c82-fe8e999e063f.docs.buildwithfern.com |
DevRev.shouldDismissModalsOnOpenLink: Bool | ||
``` | ||
|
||
### Dynamic Theme Configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
### Dynamic Theme Configuration | ||
|
||
The DevRev SDK allows you to configure the theme dynamically based on the system appearance, or use the theme configured on the DevRev portal. By default, the theme will be dynamic and follow the system appearance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
The DevRev SDK allows you to configure the theme dynamically based on the system appearance, or use the theme configured on the DevRev portal. By default, the theme will be dynamic and follow the system appearance. | |
The DevRev SDK allows you to configure the theme dynamically based on the system appearance, or use the theme configured on the DevRev portal. By default, the theme is dynamic and follows the system appearance. |
@@ -241,6 +305,17 @@ The session recording feature includes the following methods to control the reco | |||
|`DevRev.stopRecording()` | Ends the session recording and uploads it to the portal. | | |||
|`DevRev.pauseRecording()` | Pauses the ongoing session recording. | | |||
|`DevRev.resumeRecording()` | Resumes a paused session recording. | | |||
|`DevRev.processAllOnDemandSessions()`| Stops the ongoing user recording and sends all on-demand sessions along with the current recording. | | |||
|
|||
Using this property will return the status of the session recording: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**Solution**: The DevRev SDK reports all errors in the console using Apple's Unified Logging System. Look for error messages in the subsystem `ai.devrev.sdk`. | ||
|
||
- **Issue**: Support chat won't show. | ||
- **Issue**: Support chat won't show. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using 'go' instead of 'navigate'. (EK25033)
The DevRev SDK offers automatic screen tracking to help you understand how users navigate through your app. Although view controllers are automatically tracked, you can manually track screens using the following method: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [EkLine] reported by reviewdog 🐶
Remove 'properly ' if it's not important to the meaning of the statement. (EK00006)
To properly handle push notifications, implement the following method, typically in either the `UNUserNotificationCenterDelegate.userNotificationCenter(_:didReceive:)` or `UIApplicationDelegate.application(_:didReceiveRemoteNotification:fetchCompletionHandler:)`: |
Published docs preview URL: https://devrev-preview-6b1eb12a-b4b2-4303-80d8-2b50f0b61e75.docs.buildwithfern.com |
This PR restructures the iOS SDK documentation.